Issue 6359001: Fix compilation failure on ia32 and x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6359001: Fix compilation failure on ia32 and x64. (Closed)

Created:
9 years, 11 months ago by Karl Klose

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Fix compilation failure on ia32 and x64. TBR=ager BUG= TEST=

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
	M	src/arm/lithium-codegen-arm.cc	View		3 chunks	+5 lines, -3 lines	0 comments	Download
	M	src/frames.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

I'm a bit confused about this change. Didn't some of this already land? The diff ...

9 years, 11 months ago (2011-01-14 15:30:32 UTC) #2

Karl Klose

9 years, 11 months ago (2011-01-14 15:33:46 UTC) #3

This is strange - you are right, part of the changes were in the previous
commit. I used the same git branch as for the previous commit.

On 2011/01/14 15:30:32, Mads Ager wrote:
> I'm a bit confused about this change. Didn't some of this already land? The
diff
> here seems to not be against current bleeding_edge?
> 
> The change to use DoubleRegister instead of DwVfpRegister looks good to me. :)

Expand Messages | Collapse Messages