Issue 6358012: Don't black list gconf since it's back in.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6358012: Don't black list gconf since it's back in. (Closed)

Created:
9 years, 11 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git@master

Visibility:
Public.

Description

Don't black list gconf since it's back in. BUG=chromium-os:11222 TEST=none Change-Id: I3f400da70e9cada72bfa7e632a681b56488f48ed Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=145205a

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	chromeos_blacklist	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sosa

9 years, 11 months ago (2011-01-25 22:42:35 UTC) #2

LGTM :(

On Tue, Jan 25, 2011 at 2:41 PM,  <petkov@chromium.org> wrote:
> Reviewers: sosa,
>
> Description:
> Don't black list gconf since it's back in.
>
> BUG=chromium-os:11222
> TEST=none
>
> Change-Id: I3f400da70e9cada72bfa7e632a681b56488f48ed
>
> Please review this at http://codereview.chromium.org/6358012/
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/crosutils.git@master
>
> Affected files:
>  M chromeos_blacklist
>
>
> Index: chromeos_blacklist
> diff --git a/chromeos_blacklist b/chromeos_blacklist
> index
>
fb26349a6a227d9630363440c32cf72a27dc5adc..8768a4772811caeaa3197def3036233180ab0c5f
> 100644
> --- a/chromeos_blacklist
> +++ b/chromeos_blacklist
> @@ -2,7 +2,4 @@ app-text/iso-codes
>  dev-java/icedtea
>  dev-java/icedtea6-bin
>  dev-lang/python
> -dev-libs/libIDL
> -gnome-base/gconf
> -gnome-base/orbit
>  x11-libs/libxklavier
>
>
>

Expand Messages | Collapse Messages