Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 6358008: [Mac] Organize some files into chrome/browser/ui/cocoa/tab_contents/.... (Closed)

Created:
9 years, 11 months ago by Robert Sesek
Modified:
9 years, 7 months ago
CC:
chromium-reviews, brettw-cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

[Mac] Organize some files into chrome/browser/ui/cocoa/tab_contents/. BUG=none TEST=compiles R=pinkerton Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72345

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -2075 lines) Patch
M chrome/browser/tab_contents/tab_contents_view_mac.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/bookmarks/bookmark_drag_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/dev_tools_controller.h View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/cocoa/previewable_contents_controller.h View 1 chunk +0 lines, -47 lines 0 comments Download
D chrome/browser/ui/cocoa/previewable_contents_controller.mm View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/ui/cocoa/previewable_contents_controller_unittest.mm View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/ui/cocoa/sad_tab_controller.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/ui/cocoa/sad_tab_controller.mm View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/ui/cocoa/sad_tab_controller_unittest.mm View 1 chunk +0 lines, -113 lines 0 comments Download
D chrome/browser/ui/cocoa/sad_tab_view.h View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/ui/cocoa/sad_tab_view.mm View 1 chunk +0 lines, -127 lines 0 comments Download
D chrome/browser/ui/cocoa/sad_tab_view_unittest.mm View 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/browser/ui/cocoa/sidebar_controller.h View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/ui/cocoa/tab_contents/OWNERS View 1 chunk +2 lines, -0 lines 1 comment Download
A + chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/tab_contents/sad_tab_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/cocoa/tab_contents/sad_tab_controller_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/cocoa/tab_contents/sad_tab_view.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/tab_contents/sad_tab_view.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/tab_contents/sad_tab_view_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/tab_contents/web_contents_drag_source.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/tab_contents/web_contents_drag_source.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/tab_contents/web_drag_source.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/cocoa/tab_contents/web_drag_source.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/tab_contents/web_drop_target.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/ui/cocoa/tab_contents/web_drop_target.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/tab_contents/web_drop_target_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/cocoa/tab_contents_controller.h View 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/browser/ui/cocoa/tab_contents_controller.mm View 1 chunk +0 lines, -211 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/ui/cocoa/web_contents_drag_source.h View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/browser/ui/cocoa/web_contents_drag_source.mm View 1 chunk +0 lines, -130 lines 0 comments Download
D chrome/browser/ui/cocoa/web_drag_source.h View 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/browser/ui/cocoa/web_drag_source.mm View 1 chunk +0 lines, -416 lines 0 comments Download
D chrome/browser/ui/cocoa/web_drop_target.h View 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/browser/ui/cocoa/web_drop_target.mm View 1 chunk +0 lines, -283 lines 0 comments Download
D chrome/browser/ui/cocoa/web_drop_target_unittest.mm View 1 chunk +0 lines, -166 lines 0 comments Download
M chrome/chrome_browser.gypi View 3 chunks +14 lines, -14 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Robert Sesek
http://codereview.chromium.org/6358008/diff/1/chrome/browser/ui/cocoa/tab_contents/OWNERS File chrome/browser/ui/cocoa/tab_contents/OWNERS (right): http://codereview.chromium.org/6358008/diff/1/chrome/browser/ui/cocoa/tab_contents/OWNERS#newcode2 chrome/browser/ui/cocoa/tab_contents/OWNERS:2: thakis@chromium.org Should feldstein also be in this list for ...
9 years, 11 months ago (2011-01-20 22:11:55 UTC) #1
pink (ping after 24hrs)
cc'ing avi since a lot of this moves stuff into a "tab_contents" subfolder, and we ...
9 years, 11 months ago (2011-01-20 22:23:21 UTC) #2
Robert Sesek
On 2011/01/20 22:23:21, pink wrote: > cc'ing avi since a lot of this moves stuff ...
9 years, 11 months ago (2011-01-20 22:26:02 UTC) #3
Avi (use Gerrit)
9 years, 11 months ago (2011-01-20 22:28:58 UTC) #4
Do not hinge refactoring on me. Move things around as you feel is appropriate.
I'm nowhere near worrying about things like file organization.

Powered by Google App Engine
This is Rietveld 408576698