src/array.js - Issue 6357025: ArraySplice builtin should return empty array and not alter receiver if invoked with no arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/array.js

Issue 6357025: ArraySplice builtin should return empty array and not alter receiver if invoked with no arguments. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Minor correction Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/array.js

diff --git a/src/array.js b/src/array.js

index 0d7a7cbc85e1f89a490d229fa759d047b3966fa6..10c05c2b162e155a0259840676f3140428bc65d7 100644

--- a/src/array.js

+++ b/src/array.js

@@ -607,7 +607,7 @@ function ArraySplice(start, delete_count) {

// This does not follow ECMA-262, but we do the same for

// compatibility.

var del_count = 0;

- if (num_arguments > 1) {

+ if (num_arguments != 1) {

Kevin Millikin (Chromium) 2011/01/31 12:32:03 OK. Now maybe it's clearer to change the comparis

del_count = TO_INTEGER(delete_count);

if (del_count < 0) del_count = 0;

if (del_count > len - start_i) del_count = len - start_i;

« no previous file with comments | « no previous file | src/builtins.cc » ('j') | no next file with comments »