src/array.js - Issue 6357025: ArraySplice builtin should return empty array and not alter receiver if invoked with no arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/array.js

Issue 6357025: ArraySplice builtin should return empty array and not alter receiver if invoked with no arguments. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Earlier return Created 9 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/array.js

diff --git a/src/array.js b/src/array.js

index 0d7a7cbc85e1f89a490d229fa759d047b3966fa6..86738ff33f3e69386c38c9b2aabd163d63f48904 100644

--- a/src/array.js

+++ b/src/array.js

@@ -592,6 +592,8 @@ function ArraySlice(start, end) {

function ArraySplice(start, delete_count) {

var num_arguments = %_ArgumentsLength();

+ if (num_arguments == 0) return [];

var len = TO_UINT32(this.length);

var start_i = TO_INTEGER(start);

« no previous file with comments | « no previous file | test/mjsunit/array-splice.js » ('j') | no next file with comments »