Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 6357019: PrefValueStore incorrectly DCHECK()s when handling change notification for unregistered pref. (Closed)

Created:
9 years, 10 months ago by pastarmovj
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Simplified PrefValueStore::NotifyPrefChanged. Reason for the refactoring is the need to properly handle disappearing policies. This situation arises when a managed preference is removed that only has been registered in one pref store (for example local_store) the notification is sent to all pref stores though but the profile pref store doesn't have a default value for that pref and therefore ControllingPrefStoreForPref returns INVALID_STORE which shouldn't be treated as an exceptional situation (DCHECKed). BUG=71028 TEST=unit_tests --gtest_filter=*Pref* should give pretty good coverage. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72787

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -15 lines) Patch
M chrome/browser/prefs/pref_value_store.cc View 1 chunk +4 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
pastarmovj
Please review. Bots are all happy now :)
9 years, 10 months ago (2011-01-27 10:50:47 UTC) #1
Mattias Nissler (ping if slow)
9 years, 10 months ago (2011-01-27 12:41:48 UTC) #2
LGTM, thanks for fixing.

Powered by Google App Engine
This is Rietveld 408576698