Add support for chunked encoding in ChromeFrame for POST requests. This fixes...

chrome/common/common_param_traits.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/common_param_traits.h"
 
 #include "base/time.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/content_settings.h"
 #include "chrome/common/geoposition.h"
@@ skipping 332 matching lines @@
 }
 
 // Only the net::UploadData ParamTraits<> definition needs this definition, so
 // keep this in the implementation file so we can forward declare UploadData in
 // the header.
 template <>
 struct ParamTraits<net::UploadData::Element> {
   typedef net::UploadData::Element param_type;
   static void Write(Message* m, const param_type& p) {
     WriteParam(m, static_cast<int>(p.type()));
-    if (p.type() == net::UploadData::TYPE_BYTES) {
+    if (p.type() == net::UploadData::TYPE_BYTES ||

[amit, 2011/01/26 21:42:24]

nit: It will be more readable to handle TYPE_CHUNK case in a separate 'if' or
even better in a switch/case since there are more of the if/else cases now.

[ananta, 2011/01/26 22:19:58]

Done.

+        p.type() == net::UploadData::TYPE_CHUNK) {
       m->WriteData(&p.bytes()[0], static_cast<int>(p.bytes().size()));
+      if (p.type() == net::UploadData::TYPE_CHUNK) {
+        // If this element is part of a chunk upload then send over information
+        // indicating if this is the last chunk.
+        WriteParam(m, p.is_last_chunk());
+      }
     } else if (p.type() == net::UploadData::TYPE_FILE) {
       WriteParam(m, p.file_path());
       WriteParam(m, p.file_range_offset());
       WriteParam(m, p.file_range_length());
       WriteParam(m, p.expected_file_modification_time());
     } else {
       WriteParam(m, p.blob_url());
     }
   }
   static bool Read(const Message* m, void** iter, param_type* r) {
     int type;
     if (!ReadParam(m, iter, &type))
       return false;
-    if (type == net::UploadData::TYPE_BYTES) {
+    if (type == net::UploadData::TYPE_BYTES ||
+        type == net::UploadData::TYPE_CHUNK) {
       const char* data;
       int len;
       if (!m->ReadData(iter, &data, &len))
         return false;
       r->SetToBytes(data, len);
+      if (type == net::UploadData::TYPE_CHUNK) {
+        // If this element is part of a chunk upload then we need to explicitly
+        // set the type of the element and whether it is the last chunk.
+        bool is_last_chunk = false;
+        if (!ReadParam(m, iter, &is_last_chunk))
+          return false;
+        r->set_type(net::UploadData::TYPE_CHUNK);
+        r->set_is_last_chunk(is_last_chunk);
+      }
     } else if (type == net::UploadData::TYPE_FILE) {
       FilePath file_path;
       uint64 offset, length;
       base::Time expected_modification_time;
       if (!ReadParam(m, iter, &file_path))
         return false;
       if (!ReadParam(m, iter, &offset))
         return false;
       if (!ReadParam(m, iter, &length))
         return false;
@@ skipping 14 matching lines @@
     l->append("<net::UploadData::Element>");
   }
 };
 
 void ParamTraits<scoped_refptr<net::UploadData> >::Write(Message* m,
                                                          const param_type& p) {
   WriteParam(m, p.get() != NULL);
   if (p) {
     WriteParam(m, *p->elements());
     WriteParam(m, p->identifier());
+    WriteParam(m, p->is_chunked());
   }
 }
 
 bool ParamTraits<scoped_refptr<net::UploadData> >::Read(const Message* m,
                                                         void** iter,
                                                         param_type* r) {
   bool has_object;
   if (!ReadParam(m, iter, &has_object))
     return false;
   if (!has_object)
     return true;
   std::vector<net::UploadData::Element> elements;
   if (!ReadParam(m, iter, &elements))
     return false;
   int64 identifier;
   if (!ReadParam(m, iter, &identifier))
     return false;
+  bool is_chunked = false;
+  if (!ReadParam(m, iter, &is_chunked))
+    return false;
   *r = new net::UploadData;
   (*r)->swap_elements(&elements);
   (*r)->set_identifier(identifier);
+  (*r)->set_is_chunked(is_chunked);
   return true;
 }
 
 void ParamTraits<scoped_refptr<net::UploadData> >::Log(const param_type& p,
                                                        std::string* l) {
   l->append("<net::UploadData>");
 }
 
 void ParamTraits<ThumbnailScore>::Write(Message* m, const param_type& p) {
   IPC::ParamTraits<double>::Write(m, p.boring_score);
@@ skipping 235 matching lines @@
   l->append(",");
   LogParam(p.caps_mime_type, l);
   l->append(",");
   LogParam(p.printer_defaults, l);
   l->append(",");
   LogParam(p.defaults_mime_type, l);
   l->append(")");
 }
 
 }  // namespace IPC