Issue 6357012: Use chromeos::IsBootDevicePath.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6357012: Use chromeos::IsBootDevicePath. (Closed)

Created:
9 years, 11 months ago by achuithb

Modified:
9 years, 6 months ago

Reviewers:
xiyuan

CC:
chromium-os-reviews_chromium.org

Base URL:
http://git.chromium.org/git/image-burner.git@master

Visibility:
Public.

Description

Use chromeos::IsBootDevicePath. Cleanup. BUG=chromium-os:6788 TEST=none Change-Id: I7de901f3e00c2c35bfcf78eacda4185f07b81dec Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a8e572d

Patch Set 2 : img_src -> kImgSrc #

Patch Set 3 : lint #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -28 lines)			Patch
M	image_burn_service.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	image_burn_service.cc	View		2 chunks	+1 line, -12 lines	0 comments	Download
M	image_burner_tester.cc	View	1 2	1 chunk	+8 lines, -15 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

xiyuan

LGTM http://codereview.chromium.org/6357012/diff/1/image_burner_tester.cc File image_burner_tester.cc (right): http://codereview.chromium.org/6357012/diff/1/image_burner_tester.cc#newcode83 image_burner_tester.cc:83: const char* const img_src = nit: img_src -> ...

9 years, 11 months ago (2011-01-25 17:10:28 UTC) #2

achuithb

http://codereview.chromium.org/6357012/diff/1/image_burner_tester.cc File image_burner_tester.cc (right): http://codereview.chromium.org/6357012/diff/1/image_burner_tester.cc#newcode83 image_burner_tester.cc:83: const char* const img_src = On 2011/01/25 17:10:28, xiyuan ...

9 years, 11 months ago (2011-01-25 22:25:32 UTC) #3

LGTM