Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 6357007: Make 'with' mark only variables occurring in the body as used. (Closed)

Created:
9 years, 11 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make 'with' mark only variables occurring in the body as used. Before, we conservatively marked every variable in a scope as used if the scope contained 'with'. Instead, just mark the variables occurring in the body of the with. This avoids marking 'arguments' as used whenever 'with' occurs, which incurs an extra performance penalty (a use of arguments is seen as an instruction to redirect all parameter accesses to the arguments object). Committed: http://code.google.com/p/v8/source/detail?r=6415

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M src/scopes.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M test/mjsunit/debug-evaluate-locals.js View 3 chunks +9 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
9 years, 11 months ago (2011-01-20 08:59:36 UTC) #1
Mads Ager (chromium)
9 years, 11 months ago (2011-01-20 09:17:36 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698