Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 6356012: Call sqlite3Preload() only when not using system sqlite. Modify the... (Closed)

Created:
9 years, 11 months ago by rohitrao (ping after 24h)
Modified:
9 years, 7 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Visibility:
Public.

Description

Call sqlite3Preload() only when not using system sqlite. Modify the sqlite3.h header to not include a stub definition of sqlite3Preload(). BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72637

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M app/sql/connection.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/sqlite/sqlite3.h View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rohitrao (ping after 24h)
CL as promised. I tried building this on my linux box with use_system_sqlite=1 and it ...
9 years, 11 months ago (2011-01-25 22:25:33 UTC) #1
Paweł Hajdan Jr.
LGTM
9 years, 11 months ago (2011-01-26 07:41:19 UTC) #2
rohitrao (ping after 24h)
Submitted as r72637. Thanks for the review. I don't expect this to cause any problems, ...
9 years, 11 months ago (2011-01-26 14:54:21 UTC) #3
Paweł Hajdan Jr.
9 years, 11 months ago (2011-01-26 14:57:43 UTC) #4
No worries, use_system_sqlite is busted anyway, due to
http://code.google.com/p/chromium/issues/detail?id=70589

On Wed, Jan 26, 2011 at 15:45, Rohit Rao <rohitrao@chromium.org> wrote:

> Submitted as r72637.  Thanks for the review.
>
> I don't expect this to cause any problems, but I've probably just gone
> and jinxed myself.  Please let me know if you hear of anyone having
> problems and I'll roll this back.
>
> - Rohit
>
> On Wed, Jan 26, 2011 at 2:41 AM,  <phajdan.jr@chromium.org> wrote:
> > LGTM
> >
> > http://codereview.chromium.org/6356012/
> >
>

Powered by Google App Engine
This is Rietveld 408576698