Issue 6356009: Pull down new GB/AU dictionaries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6356009: Pull down new GB/AU dictionaries. (Closed)

Created:
9 years, 11 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Hironori Bono

CC:
chromium-reviews, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Pull down new GB/AU dictionaries. BUG=5509 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72606

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -14 lines)			Patch
M	DEPS	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/spellcheck_common.cc	View		3 chunks	+5 lines, -9 lines	0 comments	Download
M	chrome/renderer/spellchecker/spellcheck_unittest.cc	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download

Total messages: 5 (0 generated)

Hironori Bono

LGTM. By the way, have you updated the DEPS file to pull new en-GB and ...

9 years, 11 months ago (2011-01-25 03:06:33 UTC) #2

Evan Stade

ah, thanks for reminding me. I've updated the DEPS as well as spellcheck_unittest

9 years, 11 months ago (2011-01-25 22:25:39 UTC) #3

Evan Stade

(trybots are red because of DEPS change, but it works locally)

9 years, 11 months ago (2011-01-26 02:01:31 UTC) #4

Hironori Bono

9 years, 11 months ago (2011-01-26 02:11:31 UTC) #5

LGTM again.
Thank you for your change, including the test change.

Regards,

Hironori Bono