Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: chrome/service/cloud_print/printer_job_handler.cc

Issue 6356007: Added a diagnostic user message when enumerating printers fails. Also tweaked... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Code review changes Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/service/cloud_print/printer_job_handler.h ('k') | printing/backend/print_backend.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/service/cloud_print/printer_job_handler.cc
===================================================================
--- chrome/service/cloud_print/printer_job_handler.cc (revision 72357)
+++ chrome/service/cloud_print/printer_job_handler.cc (working copy)
@@ -65,8 +65,13 @@
printer_watcher_->StartWatching(this);
CheckForJobs(kJobFetchReasonStartup);
} else {
- // This printer does not exist any more. Delete it from the server.
- OnPrinterDeleted();
+ // This printer does not exist any more. Check if we should delete it from
+ // the server.
+ bool delete_from_server = false;
+ delegate_->OnPrinterNotFound(printer_info_.printer_name,
+ &delete_from_server);
+ if (delete_from_server)
+ OnPrinterDeleted();
}
return true;
}
« no previous file with comments | « chrome/service/cloud_print/printer_job_handler.h ('k') | printing/backend/print_backend.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698