Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tools/emacs/trybot.el

Issue 6355015: emacs: also handle paths like "..\chrome/foo/bar" seen in build output (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/emacs/trybot-windows.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/emacs/trybot.el
diff --git a/tools/emacs/trybot.el b/tools/emacs/trybot.el
index 2c658976f06001388e10fdb5e292ad56c370602f..970ffc085d9447d2f50ab5211533b9af5f047c4c 100644
--- a/tools/emacs/trybot.el
+++ b/tools/emacs/trybot.el
@@ -45,7 +45,15 @@
; Fix Windows paths ("d:\...\src\").
(save-excursion
- (while (re-search-forward "\\(^.:\\\\.*\\\\src\\\\\\)\\(.*?\\)[(:]" nil t)
+ ; This regexp is subtle and rather hard to read. :~(
+ ; Use regexp-builder when making changes to it.
+ (while (re-search-forward
+ (concat
+ ; First part: path leader, either of the form
+ ; e:\...src\ or ..\
+ "\\(^.:\\\\.*\\\\src\\\\\\|\\.\\.\\\\\\)"
+ ; Second part: path, followed by error message marker.
+ "\\(.*?\\)[(:]") nil t)
(replace-match "" nil t nil 1)
; Line now looks like:
; foo\bar\baz.cc error message here
« no previous file with comments | « no previous file | tools/emacs/trybot-windows.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698