Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 6355010: clang: Make it possible to add a plugin through GYP_DEFINES (Closed)

Created:
9 years, 11 months ago by Nico
Modified:
9 years, 7 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

clang: Make it possible to add a plugin through GYP_DEFINES With this CL, one can run GYP_DEFINES='clang=1 clang_load=/Users/thakis/src/llvm-svn/tools/clang/examples/PrintFunctionNames/libPrintFunctionNames.dylib clang_plugin=print-fns' gclient runhooks and then the normal build will run with the clang example plugin. I'm not sure if this is the best way to run Elliot's plugin, but it's useful for local one-off runs. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72924

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 1

Patch Set 5 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M build/common.gypi View 1 2 3 4 3 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
9 years, 11 months ago (2011-01-28 00:58:35 UTC) #1
Evan Martin
LGTM, maybe elliot has opinions http://codereview.chromium.org/6355010/diff/7001/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/6355010/diff/7001/build/common.gypi#newcode273 build/common.gypi:273: 'clang_load%': '', Can you ...
9 years, 11 months ago (2011-01-28 01:04:36 UTC) #2
Elliot Glaysher
My opinion is that this should be committed immediately so I won't need to locally ...
9 years, 11 months ago (2011-01-28 01:11:20 UTC) #3
Nico
9 years, 11 months ago (2011-01-28 01:20:53 UTC) #4
added a comment

Powered by Google App Engine
This is Rietveld 408576698