Issue 6355005: base/i18n: Add namespace i18n to CharIterator.

Issue 6355005: base/i18n: Add namespace i18n to CharIterator. (Closed)

Created:
9 years, 11 months ago by tfarina

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, nkostylev+cc_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, jshin+watch_chromium.org, brettw-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

base/i18n: Add namespace i18n to CharIterator. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71910

Patch Set 3 : brett review #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -19 lines)			Patch
M	app/text_elider.cc	View		3 chunks	+2 lines, -3 lines	0 comments	Download
M	base/i18n/char_iterator.h	View		4 chunks	+5 lines, -3 lines	0 comments	Download
M	base/i18n/char_iterator.cc	View	1 2	5 chunks	+9 lines, -1 line	0 comments	Download
M	base/i18n/char_iterator_unittest.cc	View	1 2	5 chunks	+11 lines, -5 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_accessibility_handler.cc	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	webkit/plugins/ppapi/event_conversion.cc	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

brettw

http://codereview.chromium.org/6355005/diff/3001/base/i18n/char_iterator.cc File base/i18n/char_iterator.cc (right): http://codereview.chromium.org/6355005/diff/3001/base/i18n/char_iterator.cc#newcode13 base/i18n/char_iterator.cc:13: // UTF8CharIterator ----------------------------------------------------------- I probably wouldn't bother adding these ...

9 years, 11 months ago (2011-01-18 18:36:10 UTC) #2

tfarina

9 years, 11 months ago (2011-01-18 18:42:04 UTC) #3

LGTM

Expand Messages | Collapse Messages