Issue 6355003: net: don't assume that we have an SSLHostInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6355003: net: don't assume that we have an SSLHostInfo. (Closed)

Created:
9 years, 11 months ago by agl

Modified:
9 years, 7 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

net: don't assume that we have an SSLHostInfo. sync doesn't run an HttpCache and therefore sync's requests don't pickup an SSLHostInfo. BUG=69522 TEST=don't crash on startup

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	net/socket/ssl_client_socket_pool.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

9 years, 11 months ago (2011-01-14 15:41:06 UTC) #2

LGTM as a crash fix.

It makes me wonder if it's a problem that SSL sockets initiated for the same
socket pool, but not for the same HttpCache may not do the same thing, but sit
in the same pool.  Sync will only do this for 1 socket, so maybe it doesn't
matter.  I'll keep it in mind for the future.

Expand Messages | Collapse Messages