Issue 6355001: Unregister previous ChromeFrame UA strings registered under the PostPlatform ...

Issue 6355001: Unregister previous ChromeFrame UA strings registered under the PostPlatform ... (Closed)

Created:
9 years, 11 months ago by ananta

Modified:
9 years, 6 months ago

Reviewers:
amit

CC:
chromium-reviews, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Unregister previous ChromeFrame UA strings registered under the PostPlatform key while registering a new ChromeFrame UA string. This ensures that we don't end up with a number of duplicated chrome frame UA strings each pointing to a different version. This should hopefully fix the InstallFlowTest. BUG=none TEST=Covered by existing ChromeFrame InstallFlowTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71466

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 6

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -3 lines)			Patch
	M	chrome_frame/chrome_tab.cc	View	1 2 3 4 5 6	1 chunk	+25 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

amit

http://codereview.chromium.org/6355001/diff/1/chrome_frame/chrome_tab.cc File chrome_frame/chrome_tab.cc (right): http://codereview.chromium.org/6355001/diff/1/chrome_frame/chrome_tab.cc#newcode454 chrome_frame/chrome_tab.cc:454: // If we are registering the ChromeFrame UA in ...

9 years, 11 months ago (2011-01-14 05:26:01 UTC) #2

amit

lgtm http://codereview.chromium.org/6355001/diff/8001/chrome_frame/chrome_tab.cc File chrome_frame/chrome_tab.cc (right): http://codereview.chromium.org/6355001/diff/8001/chrome_frame/chrome_tab.cc#newcode446 chrome_frame/chrome_tab.cc:446: for (DWORD value_index = 0; value_index < ua_key.ValueCount(); ...

9 years, 11 months ago (2011-01-14 06:38:45 UTC) #3

ananta

9 years, 11 months ago (2011-01-14 06:44:11 UTC) #4

http://codereview.chromium.org/6355001/diff/8001/chrome_frame/chrome_tab.cc
File chrome_frame/chrome_tab.cc (right):

http://codereview.chromium.org/6355001/diff/8001/chrome_frame/chrome_tab.cc#n...
chrome_frame/chrome_tab.cc:446: for (DWORD value_index = 0; value_index <
ua_key.ValueCount();
On 2011/01/14 06:38:51, amit wrote:
> nit: while (value_index < ua_key.ValueCount()) and increment if !MatchPattern?

Done.

http://codereview.chromium.org/6355001/diff/8001/chrome_frame/chrome_tab.cc#n...
chrome_frame/chrome_tab.cc:451: LRESULT ret = ::RegEnumValue(ua_key.Handle(),
On 2011/01/14 06:38:51, amit wrote:
> nit: fit more on one line to match rest of the source file?

Done.

http://codereview.chromium.org/6355001/diff/8001/chrome_frame/chrome_tab.cc#n...
chrome_frame/chrome_tab.cc:459: if (MatchPattern(name, chrome_frame_ua_pattern))
{
On 2011/01/14 06:38:51, amit wrote:
> A simple StartsWith is enough instead of MatchPattern?

Done.

Expand Messages | Collapse Messages