Issue 6354025: Add hide icon on the click-to-play UI too.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6354025: Add hide icon on the click-to-play UI too. (Closed)

Created:
9 years, 11 months ago by Chris Evans

Modified:
9 years, 6 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Add hide icon on the click-to-play UI too. BUG=63695 TEST=see bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72699

Patch Set 1 #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -2 lines)			Patch
M	chrome/renderer/blocked_plugin.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/renderer/blocked_plugin.cc	View	3 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/renderer/resources/click_to_play_plugin.html	View	3 chunks	+19 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Chris Evans

Sorry it took me a while to add it. I was being selfishly content in ...

9 years, 11 months ago (2011-01-26 07:34:11 UTC) #1

Bernhard Bauer

9 years, 11 months ago (2011-01-26 08:37:48 UTC) #2

LGTM.

http://codereview.chromium.org/6354025/diff/1/chrome/renderer/resources/click...
File chrome/renderer/resources/click_to_play_plugin.html (right):

http://codereview.chromium.org/6354025/diff/1/chrome/renderer/resources/click...
chrome/renderer/resources/click_to_play_plugin.html:94: style =
getComputedStyle(size);
Ooh, I have to remember that one. We might want to degrade some other parts of
the UI (icon, text) as well if the size gets too small.

Expand Messages | Collapse Messages