Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4550)

Unified Diff: chrome/browser/browser_main.cc

Issue 6354023: Added a function to BrowserMainParts that is called after about_flags has con... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browser_main.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_main.cc
===================================================================
--- chrome/browser/browser_main.cc (revision 72523)
+++ chrome/browser/browser_main.cc (working copy)
@@ -201,7 +201,6 @@
SocketTimeoutFieldTrial();
ProxyConnectionsFieldTrial();
SpdyFieldTrial();
- PrefetchFieldTrial();
ConnectBackupJobsFieldTrial();
InitializeSSL();
@@ -225,6 +224,11 @@
PostEarlyInitialization();
}
+// This will be called after the command-line has been mutated by about:flags
+void BrowserMainParts::PostAboutFlagsConvertedToSwitches() {
+ PrefetchFieldTrial();
+}
+
// This is an A/B test for the maximum number of persistent connections per
// host. Currently Chrome, Firefox, and IE8 have this value set at 6. Safari
// uses 4, and Fasterfox (a plugin for Firefox that supposedly configures it to
@@ -1261,6 +1265,10 @@
base::Time::Now().ToTimeT());
}
+ // Now the command line has been mutated based on about:flags, we can run some
+ // field tests
+ parts->PostAboutFlagsConvertedToSwitches();
cbentzel 2011/01/25 21:50:21 This should be done directly after ConvertFlagsToS
dominich 2011/01/25 22:00:45 Done.
+
#if defined(OS_MACOSX)
// Get the Keychain API to register for distributed notifications on the main
// thread, which has a proper CFRunloop, instead of later on the I/O thread,
@@ -1398,8 +1406,6 @@
}
#endif
- // Modifies the current command line based on active experiments on
- // about:flags.
Profile* profile = CreateProfile(parameters, user_data_dir);
if (!profile)
return ResultCodes::NORMAL_EXIT;
« no previous file with comments | « chrome/browser/browser_main.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698