Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 6354017: Allow CDSA/CSSM to be used on worker threads in debug builds (Closed)

Created:
9 years, 11 months ago by Ryan Sleevi
Modified:
9 years, 7 months ago
Reviewers:
wtc
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Allow CDSA/CSSM to be used on worker threads in debug builds by making both the CSSM init singleton and the Mac Security Services lock singleton leaky. This primarily affects the use of <keygen> in a debug build, as the RSA private key is generated on a worker thread and needs to hold the Mac Security Services lock. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72580

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M base/crypto/cssm_init.cc View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Ryan Sleevi
wtc: Just a minor change, matching the leakiness of NSS, so that <keygen> can be ...
9 years, 11 months ago (2011-01-23 22:42:40 UTC) #1
wtc
9 years, 11 months ago (2011-01-25 00:55:17 UTC) #2
LGTM.

Nit: in the CL's description, change
    CSSM lock Singleton
to
    Mac Security Services lock Singleton

Powered by Google App Engine
This is Rietveld 408576698