Fix layout glitches in NTP. Also, lots of naming cleanup.

Fix layout glitches in NTP. Also, lots of naming cleanup.

BUG=68677, 67273
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72255

[Aaron Boodman, 2011-01-22 00:38:41]

It's still nowhere near beautiful, but I think this is an improvement.

http://codereview.chromium.org/6354016/diff/1/chrome/browser/resources/new_ne...
File chrome/browser/resources/new_new_tab.html (left):

http://codereview.chromium.org/6354016/diff/1/chrome/browser/resources/new_ne...
chrome/browser/resources/new_new_tab.html:315: shownSections &=
~MINIMIZED_THUMB;
We no longer need to torture shownSections this way. Previously,
setSectionVisible would look at the current state of shownSections and do
nothing if there was nothing to do. So this code purposely lied about the
current state to force those functions to run. Instead, just changed those
functions to ignore current state and always reset.

http://codereview.chromium.org/6354016/diff/1/chrome/browser/resources/new_ne...
chrome/browser/resources/new_new_tab.html:336:
$('apps').classList.add('disabled');
No longer need this because we now have separate classes for 'disabled' and
'menu'.

http://codereview.chromium.org/6354016/diff/1/chrome/browser/resources/new_ne...
File chrome/browser/resources/new_new_tab.js (left):

http://codereview.chromium.org/6354016/diff/1/chrome/browser/resources/new_ne...
chrome/browser/resources/new_new_tab.js:35: el =
getSectionMenuButton(sectionId);
updateMenuSections() (called by layoutSections()) now handles setting the
display of the button.

http://codereview.chromium.org/6354016/diff/1/chrome/browser/resources/new_ne...
chrome/browser/resources/new_new_tab.js:710: if (!(shownSections &
MINIMIZED_RECENT)) {
No longer need to protect removing 'disabled' here because the element won't be
shown unless 'menu' is also removed.

http://codereview.chromium.org/6354016/diff/1/chrome/browser/resources/ntp/ap...
File chrome/browser/resources/ntp/apps.js (left):

http://codereview.chromium.org/6354016/diff/1/chrome/browser/resources/ntp/ap...
chrome/browser/resources/ntp/apps.js:69: if (!data.showLauncher ||
(shownSections & MINIMIZED_APPS)) {
The second part of the check is no longer needed because we now set 'disabled'
and 'minimized' separately.

[arv (Not doing code reviews), 2011-01-22 00:57:54]

Thanks for cleaning this up

http://codereview.chromium.org/6354016/diff/3001/chrome/browser/resources/new...
File chrome/browser/resources/new_new_tab.css (right):

http://codereview.chromium.org/6354016/diff/3001/chrome/browser/resources/new...
chrome/browser/resources/new_new_tab.css:349: class for this so that when a
section is un-disabled, it can go back to its
s/un-disabled/enabled/

http://codereview.chromium.org/6354016/diff/3001/chrome/browser/resources/new...
File chrome/browser/resources/new_new_tab.html (right):

http://codereview.chromium.org/6354016/diff/3001/chrome/browser/resources/new...
chrome/browser/resources/new_new_tab.html:312: var appsInitiallyMenu =
(shownSections & MENU_APPS);
too many parens

[Aaron Boodman, 2011-01-22 01:26:22]

http://codereview.chromium.org/6354016/diff/3001/chrome/browser/resources/new...
File chrome/browser/resources/new_new_tab.css (right):

http://codereview.chromium.org/6354016/diff/3001/chrome/browser/resources/new...
chrome/browser/resources/new_new_tab.css:349: class for this so that when a
section is un-disabled, it can go back to its
On 2011/01/22 00:57:54, arv wrote:
> s/un-disabled/enabled/

Done.

http://codereview.chromium.org/6354016/diff/3001/chrome/browser/resources/new...
File chrome/browser/resources/new_new_tab.html (right):

http://codereview.chromium.org/6354016/diff/3001/chrome/browser/resources/new...
chrome/browser/resources/new_new_tab.html:312: var appsInitiallyMenu =
(shownSections & MENU_APPS);
On 2011/01/22 00:57:54, arv wrote:
> too many parens

Done.

[arv (Not doing code reviews), 2011-01-22 01:44:40]

LGTM