Issue 6354014: webkit: expose webkit branch and revision number in about pages

Issue 6354014: webkit: expose webkit branch and revision number in about pages (Closed)

Created:
9 years, 11 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews, darin-cc_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

webkit: expose webkit branch and revision number in about pages - Change lastchange.py to work in other directories and to provide SVN URL. - Use lastchange.py in place where we generate WebKit versioning info. - Include branch@revision string in glue API. BUG=41264 TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72245

Patch Set 1 #

Total comments: 1

Patch Set 2 : better #

Total comments: 1

Patch Set 3 : retry #

Patch Set 4 : strip #

Total comments: 4

Patch Set 5 : ready for commit #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+108 lines, -31 lines)			Patch
M	build/util/lastchange.py	View	1 2 3 4	2 chunks	+46 lines, -21 lines	0 comments	Download
M	webkit/build/webkit_version.py	View	1 2 3 4	3 chunks	+40 lines, -4 lines	0 comments	Download
M	webkit/glue/user_agent.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/user_agent.cc	View	1	1 chunk	+8 lines, -2 lines	0 comments	Download
M	webkit/glue/webkit_glue.gypi	View	1 2	1 chunk	+13 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

http://codereview.chromium.org/6354014/diff/1/webkit/glue/webkit_glue.gypi File webkit/glue/webkit_glue.gypi (right): http://codereview.chromium.org/6354014/diff/1/webkit/glue/webkit_glue.gypi#newcode130 webkit/glue/webkit_glue.gypi:130: 'action': ['python', '<(script)', '<(version_file)', '<(INTERMEDIATE_DIR)'], fixed wrapping in followup ...

9 years, 11 months ago (2011-01-21 20:29:34 UTC) #1

Evan Martin

http://i.imgur.com/OZI5i.png (new version has parens around the URL)

9 years, 11 months ago (2011-01-21 20:45:57 UTC) #2

tony

LGTM http://codereview.chromium.org/6354014/diff/4001/build/util/lastchange.py File build/util/lastchange.py (right): http://codereview.chromium.org/6354014/diff/4001/build/util/lastchange.py#newcode48 build/util/lastchange.py:48: return (url, revision) Down with returning tuples! Can ...

9 years, 11 months ago (2011-01-21 21:18:23 UTC) #3

Evan Martin

OK, new version up that just shows WebKit: 534.16 (trunk@76347) in the about page.

9 years, 11 months ago (2011-01-21 22:47:48 UTC) #4

tony

LGTM, just some small style nits http://codereview.chromium.org/6354014/diff/10001/build/util/lastchange.py File build/util/lastchange.py (right): http://codereview.chromium.org/6354014/diff/10001/build/util/lastchange.py#newcode30 build/util/lastchange.py:30: a tuple of ...

9 years, 11 months ago (2011-01-21 22:59:58 UTC) #5

the BUG= number seems to be wrong.

Expand Messages | Collapse Messages