Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 6354006: Prepare push to trunk. We are now working in 3.0.9. (Closed)

Created:
9 years, 11 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Prepare push to trunk. We are now working in 3.0.9. Committed: http://code.google.com/p/v8/source/detail?r=6343

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M ChangeLog View 1 2 chunks +17 lines, -2 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Thygesen Gjesse
9 years, 11 months ago (2011-01-17 09:18:36 UTC) #1
Mads Ager (chromium)
Nits in the ChangeLog, otherwise LGTM http://codereview.chromium.org/6354006/diff/1/ChangeLog File ChangeLog (right): http://codereview.chromium.org/6354006/diff/1/ChangeLog#newcode8 ChangeLog:8: Hardend the implementation ...
9 years, 11 months ago (2011-01-17 09:21:27 UTC) #2
Rico
Drive by http://codereview.chromium.org/6354006/diff/1/ChangeLog File ChangeLog (right): http://codereview.chromium.org/6354006/diff/1/ChangeLog#newcode1 ChangeLog:1: 2010-01-17: Version 3.0.8 2011 + last two ...
9 years, 11 months ago (2011-01-17 09:21:46 UTC) #3
Søren Thygesen Gjesse
9 years, 11 months ago (2011-01-17 09:33:26 UTC) #4
http://codereview.chromium.org/6354006/diff/1/ChangeLog
File ChangeLog (right):

http://codereview.chromium.org/6354006/diff/1/ChangeLog#newcode1
ChangeLog:1: 2010-01-17: Version 3.0.8
On 2011/01/17 09:21:46, Rico wrote:
> 2011 + last two entries

Done.

http://codereview.chromium.org/6354006/diff/1/ChangeLog#newcode8
ChangeLog:8: Hardend the implementation of of error objects to avoid setters
On 2011/01/17 09:21:27, Mads Ager wrote:
> Hardend -> Hardened
> 
> of of -> of
> 
> Also, can we consistently use past tense?

Done.

Powered by Google App Engine
This is Rietveld 408576698