Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 6354004: Fixing search_engines.SearchEnginesTest.testDiscoverSearchEngine (Closed)

Created:
9 years, 11 months ago by rohitbm
Modified:
9 years, 3 months ago
Reviewers:
Nirnimesh
CC:
chromium-reviews
Visibility:
Public.

Description

Adding 1 minute of waiting in discover search engine test. And moved _CallFunctionWithNewTimeout to test_utils. BUG=69619 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71535

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -20 lines) Patch
M functional/downloads.py View 1 2 5 chunks +5 lines, -19 lines 0 comments Download
M functional/search_engines.py View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M functional/test_utils.py View 1 2 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rohitbm
9 years, 11 months ago (2011-01-15 01:05:27 UTC) #1
Nirnimesh
http://codereview.chromium.org/6354004/diff/2001/functional/test_utils.py File functional/test_utils.py (right): http://codereview.chromium.org/6354004/diff/2001/functional/test_utils.py#newcode12 functional/test_utils.py:12: import logging In dictionary order, logging goes before types, ...
9 years, 11 months ago (2011-01-15 01:46:28 UTC) #2
Nirnimesh
Please refer to your bug in the description BUG=????
9 years, 11 months ago (2011-01-15 01:46:52 UTC) #3
rohitbm
I have uploaded the code with changes. Thanks, Rohit On 2011/01/15 01:46:28, Nirnimesh wrote: > ...
9 years, 11 months ago (2011-01-15 01:55:10 UTC) #4
Nirnimesh
9 years, 11 months ago (2011-01-15 02:00:09 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698