Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 6353014: Fix bug 1070: set correct holder for primitive checks. (Closed)

Created:
9 years, 11 months ago by Vitaly Repeshko
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Fix bug 1070: set correct holder for primitive checks. Code generated for checks starting with primitive receivers skips one step in the usual prototype checking algorithm, so the holder must always be set. Not setting the holder did not cause an immediate failure because our primitives have additional hidden prototypes before the real prototypes. These extra objects in the chain usually contain no properties and so allowed the right holders to be selected. Committed: http://code.google.com/p/v8/source/detail?r=6459

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M src/ast.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M test/mjsunit/string-charcodeat.js View 2 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Vitaly Repeshko
9 years, 11 months ago (2011-01-25 00:31:05 UTC) #1
fschneider
9 years, 11 months ago (2011-01-25 12:06:57 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698