Check that we've got a complete header before accessing its fields.

Check that we've got a complete header before accessing its fields.
BUG=70376
TEST=none

[Evgeniy Stepanov, 2011-01-21 13:00:26]

I'm not familiar with this code. Is returning NULL a correct behavior in the
case of an incomplete packet?

[darin (slow to review), 2011-01-21 17:49:10]

LGTM

[willchan no longer on Chromium, 2011-01-21 20:04:29]

LGTM, but please add a test.

[Evgeniy Stepanov, 2011-01-24 08:54:32]

On 2011/01/21 20:04:29, willchan wrote:
> LGTM, but please add a test.

That's problematic. The only negative effect here is read-after-free, which can
lead to a segfault. If we are lucky and the memory page is allocated and
readable, the value read from it does not affect function behaviour.

[willchan no longer on Chromium, 2011-01-24 17:47:49]

use-after-free will trigger a valgrind error when we run base_unittests
under valgrind, so it sounds useful to add.

On Mon, Jan 24, 2011 at 12:54 AM, <eugenis@google.com> wrote:

> On 2011/01/21 20:04:29, willchan wrote:
>
>> LGTM, but please add a test.
>>
>
> That's problematic. The only negative effect here is read-after-free, which
> can
> lead to a segfault. If we are lucky and the memory page is allocated and
> readable, the value read from it does not affect function behaviour.
>
>
> http://codereview.chromium.org/6353010/
>

[Evgeniy Stepanov, 2011-01-25 09:30:44]

On 2011/01/24 17:47:49, willchan wrote:
> use-after-free will trigger a valgrind error when we run base_unittests
> under valgrind, so it sounds useful to add.

Done. This test would have caught the bug under Valgrind.

[Evgeniy Stepanov, 2011-01-26 11:35:22]

On 2011/01/25 09:30:44, Evgeniy Stepanov wrote:
> On 2011/01/24 17:47:49, willchan wrote:
> > use-after-free will trigger a valgrind error when we run base_unittests
> > under valgrind, so it sounds useful to add.
> 
> Done. This test would have caught the bug under Valgrind.

Adding missing file (pickle.h) to the CL.

[willchan no longer on Chromium, 2011-01-26 15:35:59]

LGTM

On Wed, Jan 26, 2011 at 3:35 AM, <eugenis@google.com> wrote:

> On 2011/01/25 09:30:44, Evgeniy Stepanov wrote:
>
>> On 2011/01/24 17:47:49, willchan wrote:
>> > use-after-free will trigger a valgrind error when we run base_unittests
>> > under valgrind, so it sounds useful to add.
>>
>
>  Done. This test would have caught the bug under Valgrind.
>>
>
> Adding missing file (pickle.h) to the CL.
>
>
> http://codereview.chromium.org/6353010/
>