Issue 6353007: ExistingUserController is used for login under automation tests.

Issue 6353007: ExistingUserController is used for login under automation tests. (Closed)

Created:
9 years, 11 months ago by whywhat

Modified:
9 years, 7 months ago

Reviewers:
Dmitry Polukhin

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

ExistingUserController is used for login under automation tests. BUG=chromiumos:7214 TEST=Run desktopui_ChromeFirstRender autotest and verify that it passes. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72478

Patch Set 1 #

Total comments: 2

Patch Set 2 : Moved check to existing user controller #

Patch Set 3 : Fixed browsertests #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -533 lines)			Patch
M	chrome/browser/automation/automation_provider_chromeos.cc	View		1 chunk	+6 lines, -11 lines	0 comments	Download
M	chrome/browser/chromeos/login/existing_user_controller.cc	View	1	1 chunk	+5 lines, -1 line	0 comments	Download
D	chrome/browser/chromeos/login/login_screen.h	View	1 2	1 chunk	+0 lines, -90 lines	0 comments	Download
D	chrome/browser/chromeos/login/login_screen.cc	View	1 2	1 chunk	+0 lines, -142 lines	0 comments	Download
D	chrome/browser/chromeos/login/login_screen_browsertest.cc	View	1 2	1 chunk	+0 lines, -140 lines	0 comments	Download
M	chrome/browser/chromeos/login/new_user_view.h	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/screen_observer.h	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller.h	View	1	8 chunks	+7 lines, -18 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller.cc	View	1	11 chunks	+29 lines, -90 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller_browsertest.cc	View	1	11 chunks	+15 lines, -32 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Dmitry Polukhin

http://codereview.chromium.org/6353007/diff/1/chrome/browser/chromeos/login/wizard_controller.cc File chrome/browser/chromeos/login/wizard_controller.cc (right): http://codereview.chromium.org/6353007/diff/1/chrome/browser/chromeos/login/wizard_controller.cc#newcode811 chrome/browser/chromeos/login/wizard_controller.cc:811: bool WizardController::IsAutomationTest() { Please remove it and make appropriate ...

9 years, 11 months ago (2011-01-21 10:26:23 UTC) #2

whywhat

Please, take another look. I've removed .h/.cc files as well. http://codereview.chromium.org/6353007/diff/1/chrome/browser/chromeos/login/wizard_controller.cc File chrome/browser/chromeos/login/wizard_controller.cc (right): http://codereview.chromium.org/6353007/diff/1/chrome/browser/chromeos/login/wizard_controller.cc#newcode811 ...

9 years, 11 months ago (2011-01-25 08:24:00 UTC) #3

LGTM

Expand Messages | Collapse Messages