Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 6353002: Fix win64 build by using int instead of size_t for position in StringBuilder... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
76 if (!FLAG_code_comments) return; 76 if (!FLAG_code_comments) return;
77 char buffer[4 * KB]; 77 char buffer[4 * KB];
78 StringBuilder builder(buffer, ARRAY_SIZE(buffer)); 78 StringBuilder builder(buffer, ARRAY_SIZE(buffer));
79 va_list arguments; 79 va_list arguments;
80 va_start(arguments, format); 80 va_start(arguments, format);
81 builder.AddFormattedList(format, arguments); 81 builder.AddFormattedList(format, arguments);
82 va_end(arguments); 82 va_end(arguments);
83 83
84 // Copy the string before recording it in the assembler to avoid 84 // Copy the string before recording it in the assembler to avoid
85 // issues when the stack allocated buffer goes out of scope. 85 // issues when the stack allocated buffer goes out of scope.
86 size_t length = builder.position(); 86 int length = builder.position();
87 Vector<char> copy = Vector<char>::New(length + 1); 87 Vector<char> copy = Vector<char>::New(length + 1);
88 memcpy(copy.start(), builder.Finalize(), copy.length()); 88 memcpy(copy.start(), builder.Finalize(), copy.length());
89 masm()->RecordComment(copy.start()); 89 masm()->RecordComment(copy.start());
90 } 90 }
91 91
92 92
93 bool LCodeGen::GeneratePrologue() { 93 bool LCodeGen::GeneratePrologue() {
94 Abort("Unimplemented: %s", "GeneratePrologue"); 94 Abort("Unimplemented: %s", "GeneratePrologue");
95 return false; 95 return false;
96 } 96 }
(...skipping 1070 matching lines...) Expand 10 before | Expand all | Expand 10 after
1167 1167
1168 void LCodeGen::DoOsrEntry(LOsrEntry* instr) { 1168 void LCodeGen::DoOsrEntry(LOsrEntry* instr) {
1169 Abort("Unimplemented: %s", "DoOsrEntry"); 1169 Abort("Unimplemented: %s", "DoOsrEntry");
1170 } 1170 }
1171 1171
1172 #undef __ 1172 #undef __
1173 1173
1174 } } // namespace v8::internal 1174 } } // namespace v8::internal
1175 1175
1176 #endif // V8_TARGET_ARCH_X64 1176 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698