Issue 6352020: Remove the 'url' type from the add startup page overlay

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6352020: Remove the 'url' type from the add startup page overlay (Closed)

Created:
9 years, 11 months ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove the 'url' type from the add startup page overlay This was accidentally re-added during a bad merge; having the type causes the new built-in validation to be activated, and it's stricter than we want to be. BUG=None TEST=Enter a domain without a scheme in the add page overlay field; there shouldn't be any validation UI Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72674

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/options/add_startup_page_overlay.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

arv (Not doing code reviews)

9 years, 11 months ago (2011-01-26 20:02:38 UTC) #3

Sad :'(

erik








On Wed, Jan 26, 2011 at 11:58,  <jhawkins@chromium.org> wrote:
> Sorry, lgtm.
>
> http://codereview.chromium.org/6352020/
>

Expand Messages | Collapse Messages