No longer display background page badge on initial start after upgrade

chrome/browser/background_page_tracker.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/background_page_tracker.h"
 
 #include <set>
 #include <string>
 #include <vector>
 
@@ skipping 172 matching lines @@
 
   // We will make two passes to update the list:
   // 1) Walk our list, and make sure that there's a corresponding extension for
   //    each item in the list. If not, delete it (extension was uninstalled).
   // 2) Walk the set of currently loaded extensions and background contents, and
   //    make sure there's an entry in our list for each one. If not, create one.
 
   PrefService* prefs = GetPrefService();
   std::set<std::string> keys_to_delete;
   bool pref_modified = false;
+  // If we've never set any prefs, then this is the first launch ever, so we
+  // want to automatically mark all existing extensions as acknowledged.
+  bool first_launch =
+      prefs->GetDictionary(prefs::kKnownBackgroundPages) == NULL;
   DictionaryValue* contents =
       prefs->GetMutableDictionary(prefs::kKnownBackgroundPages);
   for (DictionaryValue::key_iterator it = contents->begin_keys();
        it != contents->end_keys(); ++it) {
     // Check to make sure that the parent extension is still enabled.
     const Extension* extension = extensions_service->GetExtensionById(
         *it, false);
     // If the extension is not loaded, add the id to our list of keys to delete
     // later (can't delete now since we're still iterating).
     if (!extension) {
@@ skipping 11 matching lines @@
   // Look for new extensions/background contents.
   const ExtensionList* list = extensions_service->extensions();
   for (ExtensionList::const_iterator iter = list->begin();
        iter != list->begin();
        ++iter) {
     // Any extension with a background page should be in our list.
     if ((*iter)->background_url().is_valid()) {
       // If we have not seen this extension ID before, add it to our list.
       if (!contents->HasKey((*iter)->id())) {
         contents->SetWithoutPathExpansion(
-            (*iter)->id(), Value::CreateBooleanValue(false));
+            (*iter)->id(), Value::CreateBooleanValue(first_launch));
         pref_modified = true;
       }
     }
   }
 
   // Add all apps with background contents also.
   BackgroundContentsService* background_contents_service =
       profile->GetBackgroundContentsService();
   std::vector<BackgroundContents*> background_contents =
       background_contents_service->GetBackgroundContents();
   for (std::vector<BackgroundContents*>::const_iterator iter =
            background_contents.begin();
        iter != background_contents.end();
        ++iter) {
      std::string application_id = UTF16ToUTF8(
          background_contents_service->GetParentApplicationId(*iter));
      if (!contents->HasKey(application_id)) {
         contents->SetWithoutPathExpansion(
-            application_id, Value::CreateBooleanValue(false));
+            application_id, Value::CreateBooleanValue(first_launch));
         pref_modified = true;
      }
   }
 
   // Register for when new pages are loaded/unloaded so we can update our list.
   registrar_.Add(this, NotificationType::EXTENSION_LOADED,
                  NotificationService::AllSources());
   registrar_.Add(this, NotificationType::EXTENSION_UNLOADED,
                  NotificationService::AllSources());
   registrar_.Add(this, NotificationType::BACKGROUND_CONTENTS_OPENED,
@@ skipping 33 matching lines @@
   prefs->ScheduleSavePersistentPrefs();
   SendChangeNotification();
 }
 
 void BackgroundPageTracker::SendChangeNotification() {
   NotificationService::current()->Notify(
       NotificationType::BACKGROUND_PAGE_TRACKER_CHANGED,
       Source<BackgroundPageTracker>(this),
       NotificationService::NoDetails());
 }