Issue 6352004: DOMUI Prefs: Add inline buttons for setting the default search engine

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6352004: DOMUI Prefs: Add inline buttons for setting the default search engine (Closed)

Created:
9 years, 11 months ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

DOMUI Prefs: Add inline buttons for setting the default search engine This is an interim solution for M10 since the final approach (drag and drop) will likely not be ready for M10. This adds inline buttons on hover/edit in the same style as the password field "Show" button, which gives a far better experience (especially when there are a lot of engines) than the old model of a single button on the side. BUG=63825 TEST=Hovering or editing a search engine should show a "Make Default" button. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71714

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -59 lines)			Patch
M	chrome/browser/resources/options/options_page.css	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	chrome/browser/resources/options/search_engine_manager.css	View	2 chunks	+31 lines, -4 lines	0 comments	Download
M	chrome/browser/resources/options/search_engine_manager.html	View	1 chunk	+1 line, -8 lines	0 comments	Download
M	chrome/browser/resources/options/search_engine_manager.js	View	2 chunks	+0 lines, -29 lines	0 comments	Download
M	chrome/browser/resources/options/search_engine_manager_engine_list.js	View	1 chunk	+19 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages