Added one testcases to Instant.

Extended the functionality of testInstantCanDismiss to include more test coverage.

BUG=None
TEST=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72093

[Venkat Yellapu, 2011-01-15 00:10:47]

Added two test cases for Instant. Pleaser review them.

-testPornNavigation
-testFindInCanDismissInstant

Thakns,
Venkat.

[Nirnimesh, 2011-01-15 00:14:34]

http://codereview.chromium.org/6352003/diff/2001/functional/instant.py
File functional/instant.py (right):

http://codereview.chromium.org/6352003/diff/2001/functional/instant.py#newcode66
functional/instant.py:66: def testPornNavigation(self):
Yeah baby!

http://codereview.chromium.org/6352003/diff/2001/functional/instant.py#newcode72
functional/instant.py:72: 'Press Enter to search')
This error mesg is unclear

http://codereview.chromium.org/6352003/diff/2001/functional/instant.py#newcode73
functional/instant.py:73: self.SetOmniboxText('xxx')
Instead of repeating these 3 lines (which's basically the same as the last 3
except for the query text), you should create a list of search items and work
these 3 lines on them.

http://codereview.chromium.org/6352003/diff/2001/functional/instant.py#newcode79
functional/instant.py:79: """Test that instant previvew is dismissed by
find-in-page."""
s/previvew/preview/

[Venkat Yellapu, 2011-01-18 02:02:26]

Reflected the changes.

Thanks.

[Nirnimesh, 2011-01-18 20:05:49]

LGTM. Will commit

http://codereview.chromium.org/6352003/diff/9001/functional/instant.py
File functional/instant.py (right):

http://codereview.chromium.org/6352003/diff/9001/functional/instant.py#newcode74
functional/instant.py:74: 'User can preview porn words without enter key')
Be consistent. use msg=

[Nirnimesh, 2011-01-18 20:10:13]

Fails on my Mac.


======================================================================
FAIL: instant.InstantTest.testPornNavigation: "Test that instant doesn't preview
porn words."
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Volumes/1/chrome/cr-git/src/chrome/test/functional/instant.py", line
71, in testPornNavigation
    self.assertTrue(self.WaitUntil(self._DoneLoading))
AssertionError


This is while using the 'xxx' keyword

[Allen, 2011-01-19 22:43:25]

http://codereview.chromium.org/6352003/diff/9001/functional/instant.py
File functional/instant.py (right):

http://codereview.chromium.org/6352003/diff/9001/functional/instant.py#newcode72
functional/instant.py:72: self.assertTrue(self.WaitUntil(self._DoneLoading))
a note: this pass condition isn't the expected behavior.  in fact, it sort of
feels like a bug in the feature that this passes in most scenarios.

the expected behavior is that the instant tab is not being shown to the users. 
oddly, by the info, it appears that on most platforms it is actually loading and
rendering like normal, but there is some other logic causing it to not be
displayed.  huyen is looking into this, because it is the same expected behavior
for another test case he picked up.

[Venkat Yellapu, 2011-01-21 02:05:03]

Removed the test testPornNavigation as per Scott's comments offline. We can
check in the other test: testFindInCanDismissInstant.

Thanks.

[Venkat Yellapu, 2011-01-21 02:17:37]

Added one testcase: testFindInCanDismissInstant for Instant.

Thanks.

[Nirnimesh, 2011-01-21 02:39:20]

Committed

[Venkat Yellapu, 2011-01-29 01:54:45]

Extended the function of testInstantCanDismiss to include more test coverage.

[Allen, 2011-01-29 02:01:36]

looks like nirnimesh already committed this one.  can you make a new cl with
your edits?

On 2011/01/29 01:54:45, venkataramana wrote:
> Extended the function of testInstantCanDismiss to include more test coverage.