Adding debugger interface and runtime functions hooks for supporting...

src/debug-debugger.js

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 91 matching lines @@
     getValue: function() { return Debug.isBreakOnUncaughtException(); },
     setValue: function(value) {
       if (value) {
         Debug.setBreakOnUncaughtException();
       } else {
         Debug.clearBreakOnUncaughtException();
       }
     }
   },
 };
+var lol_is_enabled = %HasLOLEnabled();
 
 
 // Create a new break point object and add it to the list of break points.
 function MakeBreakPoint(source_position, opt_script_break_point) {
   var break_point = new BreakPoint(source_position, opt_script_break_point);
   break_points.push(break_point);
   return break_point;
 }
 
 
@@ skipping 1262 matching lines @@
       } else if (request.command == 'backtrace') {
         this.backtraceRequest_(request, response);
       } else if (request.command == 'frame') {
         this.frameRequest_(request, response);
       } else if (request.command == 'scopes') {
         this.scopesRequest_(request, response);
       } else if (request.command == 'scope') {
         this.scopeRequest_(request, response);
       } else if (request.command == 'evaluate') {
         this.evaluateRequest_(request, response);
+      } else if (lol_is_enabled && request.command == 'getobj') {
+        this.getobjRequest_(request, response);
       } else if (request.command == 'lookup') {
         this.lookupRequest_(request, response);
       } else if (request.command == 'references') {
         this.referencesRequest_(request, response);
       } else if (request.command == 'source') {
         this.sourceRequest_(request, response);
       } else if (request.command == 'scripts') {
         this.scriptsRequest_(request, response);
       } else if (request.command == 'threads') {
         this.threadsRequest_(request, response);
       } else if (request.command == 'suspend') {
         this.suspendRequest_(request, response);
       } else if (request.command == 'version') {
         this.versionRequest_(request, response);
       } else if (request.command == 'profile') {
         this.profileRequest_(request, response);
       } else if (request.command == 'changelive') {
         this.changeLiveRequest_(request, response);
       } else if (request.command == 'flags') {
         this.debuggerFlagsRequest_(request, response);
       } else if (request.command == 'v8flags') {
         this.v8FlagsRequest_(request, response);
 
       // GC tools:
       } else if (request.command == 'gc') {
         this.gcRequest_(request, response);
 
+      // LiveObjectList tools:
+      } else if (lol_is_enabled && request.command == 'lol-capture') {
+        this.lolCaptureRequest_(request, response);
+      } else if (lol_is_enabled && request.command == 'lol-delete') {
+        this.lolDeleteRequest_(request, response);
+      } else if (lol_is_enabled && request.command == 'lol-diff') {
+        this.lolDiffRequest_(request, response);
+      } else if (lol_is_enabled && request.command == 'lol-getid') {
+        this.lolGetIdRequest_(request, response);
+      } else if (lol_is_enabled && request.command == 'lol-info') {
+        this.lolInfoRequest_(request, response);
+      } else if (lol_is_enabled && request.command == 'lol-reset') {
+        this.lolResetRequest_(request, response);
+      } else if (lol_is_enabled && request.command == 'lol-retainers') {
+        this.lolRetainersRequest_(request, response);
+      } else if (lol_is_enabled && request.command == 'lol-path') {
+        this.lolPathRequest_(request, response);
+      } else if (lol_is_enabled && request.command == 'lol-print') {
+        this.lolPrintRequest_(request, response);
+      } else if (lol_is_enabled && request.command == 'lol-stats') {
+        this.lolStatsRequest_(request, response);
+
       } else {
         throw new Error('Unknown command "' + request.command + '" in request');
       }
     } catch (e) {
       // If there is no response object created one (without command).
       if (!response) {
         response = this.createResponse();
       }
       response.success = false;
       response.message = %ToString(e);
@@ skipping 573 matching lines @@
     return;
   } else {
     // Evaluate in the selected frame.
     response.body = this.exec_state_.frame().evaluate(
         expression, Boolean(disable_break), additional_context_object);
     return;
   }
 };
 
 
+DebugCommandProcessor.prototype.getobjRequest_ = function(request, response) {
+  if (!request.arguments) {
+    return response.failed('Missing arguments');
+  }
+
+  // Pull out arguments.
+  var obj_id = request.arguments.obj_id;
+
+  // Check for legal arguments.
+  if (IS_UNDEFINED(obj_id)) {
+    return response.failed('Argument "obj_id" missing');
+  }
+
+  // Dump the object.
+  response.body = MakeMirror(%GetLOLObj(obj_id));

[Søren Thygesen Gjesse, 2011/01/19 08:36:40]

I think we should be able to unify the handles ids used by the debugger and the
object ids used in lols.

What do you think about this:

If lol is enabled then the debugger should just use the lol id instead of
generating its own handle id. That will make the ids persistent between debugger
invocations as long as lol is activated. That way we don't need both the @ and
the # ids.

This unification can be done in a separate change it it can work.

[marklam, 2011/01/19 09:04:02]

The problem with that is that the @ids only work if one has captured a lol. 
Whereas the #handle# can be used whenever the debugger breaks and the user
inspects a var.  If we unify it, then we need to fore the capture of lols every
time the user inspects a var in the debugger.  This will interfere with the
user's usage of lols because the debugger will be automatically capturing the
lols where the user didn't request any.

If we try to hide these implicitly captured lols, there are other issues with
the deletion of lols where the user may delete all lols, but we may not want to
delete the implicit ones.

Also, it introduces inconsistencies in the behavior of the merged #handles# when
lols are not in use.  @ids do not keep the GC from collecting an object, while
#handle#s do.  Hence, the user will be getting a different experience depending
on whether lols are in use or not.  This can be confusing to the user.

I think it is better to be consistent and transparent about the difference
between the 2.

+};
+
+
 DebugCommandProcessor.prototype.lookupRequest_ = function(request, response) {
   if (!request.arguments) {
     return response.failed('Missing arguments');
   }
 
   // Pull out arguments.
   var handles = request.arguments.handles;
 
   // Check for legal arguments.
   if (IS_UNDEFINED(handles)) {
@@ skipping 310 matching lines @@
   if (!type) type = 'all';
 
   var before = %GetHeapUsage();
   %CollectGarbage(type);
   var after = %GetHeapUsage();
 
   response.body = { "before": before, "after": after };
 };
 
 
+DebugCommandProcessor.prototype.lolCaptureRequest_ = function(request, response) {

[Søren Thygesen Gjesse, 2011/01/19 08:36:40]

We try to split the long lines when possible, e.g.
JSONProtocolSerializer.prototype.serializeReferenceWithDisplayData_ and
JSONProtocolSerializer.prototype.serialize_ in mirror-debugger.js

[marklam, 2011/01/19 09:04:02]

Done.

+  response.body = %CaptureLOL();
+};
+
+
+DebugCommandProcessor.prototype.lolDeleteRequest_ = function(request, response) {

[Søren Thygesen Gjesse, 2011/01/19 08:36:40]

Ditto.

[marklam, 2011/01/19 09:04:02]

Done.

+  var id = request.arguments.id;
+  var result = %DeleteLOL(id);
+  if (result) {
+    response.body = { id: id };
+  } else {
+    response.failed('Failed to delete: live object list ' + id + ' not found.');
+  }
+};
+
+
+DebugCommandProcessor.prototype.lolDiffRequest_ = function(request, response) {
+  var id1 = request.arguments.id1;
+  var id2 = request.arguments.id2;
+  var verbose = request.arguments.verbose;
+  var filter = request.arguments.filter;
+  if (verbose === true) {
+    var start = request.arguments.start;
+    var count = request.arguments.count;
+    response.body = %DumpLOL(id1, id2, start, count, filter);
+  } else {
+    response.body = %SummarizeLOL(id1, id2, filter);
+  }
+};
+
+
+DebugCommandProcessor.prototype.lolGetIdRequest_ = function(request, response) {
+  var address = request.arguments.address;
+  response.body = {};
+  response.body.id = %GetLOLObjId(address);
+};
+
+
+DebugCommandProcessor.prototype.lolInfoRequest_ = function(request, response) {
+  var start = request.arguments.start;
+  var count = request.arguments.count;
+  response.body = %InfoLOL(start, count);
+};
+
+
+DebugCommandProcessor.prototype.lolResetRequest_ = function(request, response) {
+  %ResetLOL();
+};
+
+
+DebugCommandProcessor.prototype.lolRetainersRequest_ = function(request, response) {

[Søren Thygesen Gjesse, 2011/01/19 08:36:40]

Ditto.

[marklam, 2011/01/19 09:04:02]

Done.

+  var id = request.arguments.id;
+  var verbose = request.arguments.verbose;
+  var start = request.arguments.start;
+  var count = request.arguments.count;
+  var filter = request.arguments.filter;
+
+  response.body = %GetLOLObjRetainers(id, Mirror.prototype, verbose,
+                                      start, count, filter);
+};
+
+
+DebugCommandProcessor.prototype.lolPathRequest_ = function(request, response) {
+  var id1 = request.arguments.id1;
+  var id2 = request.arguments.id2;
+  response.body = {};
+  response.body.path = %GetLOLPath(id1, id2, Mirror.prototype);
+};
+
+
+DebugCommandProcessor.prototype.lolPrintRequest_ = function(request, response) {
+  var id = request.arguments.id;
+  response.body = {};
+  response.body.dump = %PrintLOLObj(id);
+};
 
 
 // Check whether the previously processed command caused the VM to become
 // running.
 DebugCommandProcessor.prototype.isRunning = function() {
   return this.running_;
 }
 
 
 DebugCommandProcessor.prototype.systemBreak = function(cmd, args) {
@@ skipping 85 matching lines @@
     case 'string':
     case 'number':
       json = value;
       break
 
     default:
       json = null;
   }
   return json;
 }