Issue 6351001: Debugging updates for sync integration tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6351001: Debugging updates for sync integration tests (Closed)

Created:
9 years, 11 months ago by Raghu Simha

Modified:
9 years, 7 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), idana, tim (not reviewing), Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Debugging updates for sync integration tests The sync tests were using verbose logging in the past in order to help debug flaky and failing tests. Now that the tests are mostly green, the verbosity can be dialed down. This patch reduces the verbosity of sync test logging. In addition, a couple of bookmark tests occasionally fail due to a mismatch, and the logs don't make it clear where the test fails. This patch adds more detailed logging during bookmark comparison. TBR=tim@chromium.org BUG=none TEST=sync_integration_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71456

Patch Set 1 #

Patch Set 2 : Favicon size #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -15 lines)			Patch
	M	chrome/test/live_sync/bookmark_model_verifier.cc	View	1	2 chunks	+34 lines, -11 lines	0 comments	Download
	M	chrome/test/live_sync/live_sync_test.cc	View		2 chunks	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Raghu Simha

9 years, 11 months ago (2011-01-14 17:43:41 UTC) #1

Tim, please review. Thanks.

Passed trybots:
http://build.chromium.org/p/tryserver.chromium/builders/linux_sync/builds/242

Expand Messages | Collapse Messages