Introduce ToNumber stub and use it in non-optimized code for to-number conver...

Introduce ToNumber stub and use it in non-optimized code for to-number conversion.

This stub is used for increment/decrement operations and unary plus.
The resulting code is more compact and faster than calling a JS builtin.



Committed: http://code.google.com/p/v8/source/detail?r=6527

[William Hesse, 2011-01-28 14:12:28]

LGTM, with comments.

http://codereview.chromium.org/6350021/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):

http://codereview.chromium.org/6350021/diff/1/src/ia32/code-stubs-ia32.cc#new...
src/ia32/code-stubs-ia32.cc:48: __ ret(0);
Ret() is an alternative to ret(0)

http://codereview.chromium.org/6350021/diff/1/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

http://codereview.chromium.org/6350021/diff/1/src/x64/code-stubs-x64.cc#newco...
src/x64/code-stubs-x64.cc:43: // It is assumed to be already smi-checked.
This comment is probably wrong.  Otherwise, we wouldn't smi-check here.

http://codereview.chromium.org/6350021/diff/1/src/x64/code-stubs-x64.cc#newco...
src/x64/code-stubs-x64.cc:47: __ ret(0);
Ret() is an alternative to ret(0).

[fschneider, 2011-01-28 14:17:32]

http://codereview.chromium.org/6350021/diff/1/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):

http://codereview.chromium.org/6350021/diff/1/src/x64/code-stubs-x64.cc#newco...
src/x64/code-stubs-x64.cc:43: // It is assumed to be already smi-checked.
On 2011/01/28 14:12:28, William Hesse wrote:
> This comment is probably wrong.  Otherwise, we wouldn't smi-check here.

Done.

http://codereview.chromium.org/6350021/diff/1/src/x64/code-stubs-x64.cc#newco...
src/x64/code-stubs-x64.cc:47: __ ret(0);
On 2011/01/28 14:12:28, William Hesse wrote:
> Ret() is an alternative to ret(0).

Done.