Issue 6350017: A blind fix for Bug 70870...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6350017: A blind fix for Bug 70870... (Closed)

Created:
9 years, 11 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

A blind fix for Bug 70870 It seems r72539 <http://crrev.com/72539>; changed ui::GetXWindowStack() so it returns false if XGetWindowProperty() returns 0 (Success). This change just compares the return value of XGetWindowProperty() with Success as the function did before r72539. BUG=70870 TEST=make the "Linux Tests (valgrind)(1)" bot green. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72608

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	ui/base/x/x11_util.cc	View		1 chunk	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

lgtm!

Expand Messages | Collapse Messages