Issue 6350012: Switch from template functions overloading to partial template specialization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6350012: Switch from template functions overloading to partial template specialization. (Closed)

Created:
9 years, 11 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Switch from template functions overloading to partial template specialization. This should fix compilation on old GCC. Committed: http://code.google.com/p/v8/source/detail?r=6563

Patch Set 1 #

Total comments: 1

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -10 lines)			Patch
	M	src/utils.h	View		1 chunk	+22 lines, -10 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

9 years, 11 months ago (2011-01-25 10:30:40 UTC) #2

lgtm (actually it made my head hurt)

http://codereview.chromium.org/6350012/diff/1/src/utils.h
File src/utils.h (right):

http://codereview.chromium.org/6350012/diff/1/src/utils.h#newcode785
src/utils.h:785: 
Two blank lines.

Expand Messages | Collapse Messages