Issue 6350009: Take out temporary code that was needed for a two-sided WebKit patch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6350009: Take out temporary code that was needed for a two-sided WebKit patch. (Closed)

Created:
9 years, 11 months ago by jam

Modified:
9 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Take out temporary code that was needed for a two-sided WebKit patch. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72181

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -5 lines)			Patch
	M	webkit/mocks/mock_webframe.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

9 years, 11 months ago (2011-01-21 19:21:50 UTC) #2

LG

On Fri, Jan 21, 2011 at 11:10 AM,  <jam@chromium.org> wrote:
> Reviewers: Nico,
>
> Description:
> Take out temporary code that was needed for a two-sided WebKit patch.
>
> Please review this at http://codereview.chromium.org/6350009/
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     webkit/mocks/mock_webframe.h
>
>
> Index: webkit/mocks/mock_webframe.h
> ===================================================================
> --- webkit/mocks/mock_webframe.h        (revision 72155)
> +++ webkit/mocks/mock_webframe.h        (working copy)
> @@ -267,15 +267,10 @@
>   virtual bool selectWordAroundCaret() {
>     return false;
>   }
> -#if defined(WEBFRAME_PRINTBEGIN_TAKES_NODE)
>   virtual int printBegin(const WebSize& pageSize,
>                          const WebNode& constrainToNode,
>                          int printerDPI = 72,
>                          bool* useBrowserOverlays = 0) {
> -#else
> -virtual int printBegin(const WebSize& pageSize, int printerDPI = 72,
> -                         bool* useBrowserOverlays = 0) {
> -#endif
>     return 0;
>   }
>   virtual float getPrintPageShrink(int page) {
>
>
>

Expand Messages | Collapse Messages