DOMUI: Polish the navbar-container.

DOMUI: Polish the navbar-container.
* Don't bold selected navbar-items.
* Add transparent 1px border to unselected navbar-items to prevent shifting.
* Clicking on the Settings title takes you to the 'Basics' page.
* Only show the pointer when hovering navbar-items.
* Fix navbar-container background in RTL.
* Fix linear-gradient of navbar-item-selected.

BUG=69721
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=71682

[stuartmorgan, 2011-01-18 17:01:24]

LGTM

[arv (Not doing code reviews), 2011-01-18 19:01:46]

On Mon, Jan 17, 2011 at 13:32,  <jhawkins@chromium.org> wrote:
> Reviewers: stuartmorgan,
>
> Description:
> DOMUI: Polish the navbar-container.
> * Don't bold selected navbar-items.
> * Add transparent 1px border to unselected navbar-items to prevent shifting.

For future references... You can use outline and outline-offset to do
this with less hassle.

> * Clicking on the Settings title takes you to the 'Basics' page.
> * Only show the pointer when hovering navbar-items.
>
> BUG=69721
> TEST=none
>
> Please review this at http://codereview.chromium.org/6350005/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M chrome/browser/resources/options/options.js
>  M chrome/browser/resources/options/options_page.css
>
>
> Index: chrome/browser/resources/options/options.js
> diff --git a/chrome/browser/resources/options/options.js
> b/chrome/browser/resources/options/options.js
> index
>
d1efac5e3453cdb559535e8d583b8e7d52b9c2ad..9ee3f88ec8e5731df074b109736ec198528c95b2
> 100644
> --- a/chrome/browser/resources/options/options.js
> +++ b/chrome/browser/resources/options/options.js
> @@ -171,6 +171,11 @@ function load() {
>     document.documentElement.setAttribute('toolkit', 'gtk');
>   if (cr.isViews)
>     document.documentElement.setAttribute('toolkit', 'views');
> +
> +  // Clicking on the Settings title brings up the 'Basics' page.
> +  $('settings-title').onclick = function() {
> +    OptionsPage.showPageByName(BrowserOptions.getInstance().name);
> +  };
>  }
>
>  document.addEventListener('DOMContentLoaded', load);
> Index: chrome/browser/resources/options/options_page.css
> diff --git a/chrome/browser/resources/options/options_page.css
> b/chrome/browser/resources/options/options_page.css
> index
>
e2efea1c7bd23e5d957b8a46793157c128cc1c23..3fd31b66f9da61530df206c5309537c47c3b2403
> 100644
> --- a/chrome/browser/resources/options/options_page.css
> +++ b/chrome/browser/resources/options/options_page.css
> @@ -7,6 +7,7 @@ body {
>  #settings-title {
>   -webkit-padding-end: 24px;
>   color: #53637d;
> +  cursor: pointer;
>   font-size: 200%;
>   font-weight: normal;
>   margin: 0;
> @@ -121,7 +122,6 @@ html[toolkit=views] .button-strip {
>   background: -webkit-linear-gradient(rgba(234, 238, 243, 0), #eaeef3),
>               -webkit-linear-gradient(left, #eaeef3, #eaeef3 97%, #d3d7db);
>   bottom: 0;
> -  cursor: pointer;
>   display: none;
>   left: 0;
>   position: fixed;
> @@ -158,7 +158,10 @@ html[hide-menu=false] #navbar-container {
>  }
>
>  .navbar-item, .navbar-item2 {
> +  border-bottom: 1px solid transparent;
> +  border-top: 1px solid transparent;
>   color: #426dc9;
> +  cursor: pointer;
>   display: block;
>   font-size: 105%;
>   outline: none;
> @@ -172,7 +175,6 @@ html[hide-menu=false] #navbar-container {
>   border-bottom: 1px solid #8faad9;
>   border-top: 1px solid #8faad9;
>   color: black;
> -  font-weight: bold;
>  }
>
>  .navbar-item-normal {
>
>
>