Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 6350002: Remove unnecessary recording of temp operands in the register allocator.... (Closed)

Created:
9 years, 11 months ago by fschneider
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove unnecessary recording of temp operands in the register allocator. When processing register contraints we used to add writable input operands also as temp operands to the same instruction. This does not seem necessary since we create a fresh virtual register for writable inputs and insert a definition in the gap before the instruction. Committed: http://code.google.com/p/v8/source/detail?r=6342

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/lithium-allocator.cc View 1 chunk +0 lines, -1 line 1 comment Download

Messages

Total messages: 2 (0 generated)
fschneider
9 years, 11 months ago (2011-01-17 09:48:18 UTC) #1
Vyacheslav Egorov (Chromium)
9 years, 11 months ago (2011-01-17 09:54:50 UTC) #2
LGTM

http://codereview.chromium.org/6350002/diff/1/src/lithium-allocator.cc
File src/lithium-allocator.cc (left):

http://codereview.chromium.org/6350002/diff/1/src/lithium-allocator.cc#oldcod...
src/lithium-allocator.cc:840: second->AddTemp(cur_input);
Add assert that cur_input is used at end, not at start to guarantee equivalent
liveranges.

Powered by Google App Engine
This is Rietveld 408576698