Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: media/filters/decoder_base_unittest.cc

Issue 6350001: Replace MockFilterCallback with MockCallback and simplify unit tests. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src
Patch Set: forgot some files Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/filters/audio_renderer_base_unittest.cc ('k') | media/filters/ffmpeg_demuxer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/decoder_base_unittest.cc
diff --git a/media/filters/decoder_base_unittest.cc b/media/filters/decoder_base_unittest.cc
index e4cec5d024abcf8253cdc8dfd571805c4531f0f7..2fefb56e62e6b914a5d9cb622021e6a9a0aca348 100644
--- a/media/filters/decoder_base_unittest.cc
+++ b/media/filters/decoder_base_unittest.cc
@@ -4,6 +4,7 @@
#include <vector>
+#include "media/base/mock_callback.h"
#include "media/base/mock_filters.h"
#include "media/base/mock_task.h"
#include "media/filters/decoder_base.h"
@@ -121,15 +122,12 @@ TEST(DecoderBaseTest, FlowControl) {
decoder->set_consume_audio_samples_callback(
NewCallback(&read_callback, &MockDecoderCallback::OnReadComplete));
scoped_refptr<MockDemuxerStream> demuxer_stream(new MockDemuxerStream());
- StrictMock<MockFilterCallback> callback;
decoder->set_message_loop(&message_loop);
// Initailize.
- EXPECT_CALL(callback, OnFilterCallback());
- EXPECT_CALL(callback, OnCallbackDestroyed());
EXPECT_CALL(*decoder, DoInitialize(NotNull(), NotNull(), NotNull()))
.WillOnce(Initialize());
- decoder->Initialize(demuxer_stream.get(), callback.NewCallback());
+ decoder->Initialize(demuxer_stream.get(), NewExpectedCallback());
message_loop.RunAllPending();
// Read.
@@ -157,9 +155,7 @@ TEST(DecoderBaseTest, FlowControl) {
// Stop.
EXPECT_CALL(*decoder, DoStop(_))
.WillOnce(WithArg<0>(InvokeRunnable()));
- EXPECT_CALL(callback, OnFilterCallback());
- EXPECT_CALL(callback, OnCallbackDestroyed());
- decoder->Stop(callback.NewCallback());
+ decoder->Stop(NewExpectedCallback());
message_loop.RunAllPending();
}
« no previous file with comments | « media/filters/audio_renderer_base_unittest.cc ('k') | media/filters/ffmpeg_demuxer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698