Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Unified Diff: media/base/mock_filters.h

Issue 6350001: Replace MockFilterCallback with MockCallback and simplify unit tests. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src
Patch Set: forgot some files Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/mock_callback.cc ('k') | media/base/mock_filters.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/mock_filters.h
diff --git a/media/base/mock_filters.h b/media/base/mock_filters.h
index 5f43356453d7e5086f4c5e2bfd4c582e54fc3799..45c1e295e75176bd58c71d490eec4f145074fda6 100644
--- a/media/base/mock_filters.h
+++ b/media/base/mock_filters.h
@@ -15,7 +15,6 @@
#include <string>
-#include "base/callback.h"
#include "media/base/filters.h"
#include "media/base/filter_collection.h"
#include "media/base/video_frame.h"
@@ -44,56 +43,6 @@ class Destroyable : public MockClass {
DISALLOW_COPY_AND_ASSIGN(Destroyable);
};
-// Helper class used to test that callbacks are executed. It is recommend you
-// combine this class with StrictMock<> to verify that the callback is executed.
-// You can reuse the same instance of a MockFilterCallback many times since
-// gmock will track the number of times the methods are executed.
-class MockFilterCallback {
- public:
- MockFilterCallback();
- MockFilterCallback(bool run_destroy_callback);
- virtual ~MockFilterCallback();
-
- MOCK_METHOD0(OnCallbackDestroyed, void());
- MOCK_METHOD0(OnFilterCallback, void());
-
- // Helper method to create a new callback for this mock. The callback will
- // call OnFilterCallback() when executed and OnCallbackDestroyed() when
- // destroyed. Clients should use NiceMock<> or StrictMock<> depending on the
- // test.
- FilterCallback* NewCallback();
-
- private:
- // Private implementation of CallbackRunner used to trigger expectations on
- // MockFilterCallback.
- class CallbackImpl : public CallbackRunner<Tuple0> {
- public:
- explicit CallbackImpl(MockFilterCallback* mock_callback,
- bool run_destroy_callback)
- : mock_callback_(mock_callback),
- run_destroy_callback_(run_destroy_callback) {
- }
-
- virtual ~CallbackImpl() {
- if (run_destroy_callback_)
- mock_callback_->OnCallbackDestroyed();
- }
-
- virtual void RunWithParams(const Tuple0& params) {
- mock_callback_->OnFilterCallback();
- }
-
- private:
- MockFilterCallback* mock_callback_;
- bool run_destroy_callback_;
-
- DISALLOW_COPY_AND_ASSIGN(CallbackImpl);
- };
-
- bool run_destroy_callback_;
- DISALLOW_COPY_AND_ASSIGN(MockFilterCallback);
-};
-
class MockFilter : public Filter {
public:
MockFilter();
« no previous file with comments | « media/base/mock_callback.cc ('k') | media/base/mock_filters.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698