Issue 6349091: Improve error messages from tests

Issue 6349091: Improve error messages from tests (Closed)

Created:
9 years, 10 months ago by Luigi Semenzato

Modified:
9 years, 7 months ago

Reviewers:
Randall Spangler

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Bill Richardson

Base URL:
http://git.chromium.org/git/vboot_reference.git@master

Visibility:
Public.

Description

Improve error messages from tests. Change-Id: I111e0fb38188e70659d735f0949a7bdb548a258b BUG=433 TEST=compiled and ran the tests. No QA testing required. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=8e14bc0

Patch Set 1 #

Total comments: 2

Patch Set 2 : small improvements #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -23 lines)			Patch
M	tests/tpm_lite/globallock.c	View	1	3 chunks	+2 lines, -5 lines	0 comments	Download
M	tests/tpm_lite/redefine_unowned.c	View		3 chunks	+6 lines, -7 lines	0 comments	Download
M	tests/tpm_lite/tlcl_tests.h	View	1	1 chunk	+12 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Luigi Semenzato

The output from some (transient) test failures bugged me. Token LGTM would be appreciated, and ...

9 years, 10 months ago (2011-02-04 01:02:16 UTC) #1

Randall Spangler

LGTM, though I have a couple suggestions. Thanks for working on tests. http://codereview.chromium.org/6349091/diff/1/tests/tpm_lite/tlcl_tests.h File tests/tpm_lite/tlcl_tests.h ...

9 years, 10 months ago (2011-02-04 16:35:59 UTC) #2

Luigi Semenzato

9 years, 10 months ago (2011-02-04 18:09:47 UTC) #3

Thank you, changed, and will push when the tree reopens.


On 2011/02/04 16:35:59, Randall Spangler wrote:
> LGTM, though I have a couple suggestions.
> 
> Thanks for working on tests.
> 
> http://codereview.chromium.org/6349091/diff/1/tests/tpm_lite/tlcl_tests.h
> File tests/tpm_lite/tlcl_tests.h (right):
> 
>
http://codereview.chromium.org/6349091/diff/1/tests/tpm_lite/tlcl_tests.h#new...
> tests/tpm_lite/tlcl_tests.h:21: if ((_result = (tpm_command)) !=
> expected_result) {          \
> Minor nit: (expected_result)
> 
> (guard macro expansion vs. operator precedence)
> 
>
http://codereview.chromium.org/6349091/diff/1/tests/tpm_lite/tlcl_tests.h#new...
> tests/tpm_lite/tlcl_tests.h:23: __LINE__, _result);                           
 
>    \
> While we're making things more elegant, could print expected_result here too
> 
> : got 0x%x, expected 0x%x
> 
> (or similar)

Expand Messages | Collapse Messages