Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1636)

Unified Diff: chrome/browser/service/service_process_control_browsertest.cc

Issue 6349029: Get service processes working on Mac and Linux. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix up small typo in comment Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/service/service_process_control.cc ('k') | chrome/common/service_process_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/service/service_process_control_browsertest.cc
diff --git a/chrome/browser/service/service_process_control_browsertest.cc b/chrome/browser/service/service_process_control_browsertest.cc
index afe4594de827e89f89d7023c42a710a9a7dd01e9..a0dee5dcfa91ca364ee6570ad46fda022b6646d6 100644
--- a/chrome/browser/service/service_process_control_browsertest.cc
+++ b/chrome/browser/service/service_process_control_browsertest.cc
@@ -71,7 +71,8 @@ class ServiceProcessControlBrowserTest
}
void ProcessControlLaunched() {
- base::ProcessId service_pid = GetServiceProcessPid();
+ base::ProcessId service_pid;
+ EXPECT_TRUE(GetServiceProcessSharedData(NULL, &service_pid));
EXPECT_NE(static_cast<base::ProcessId>(0), service_pid);
EXPECT_TRUE(base::OpenProcessHandleWithAccess(
service_pid,
@@ -96,7 +97,6 @@ class ServiceProcessControlBrowserTest
base::ProcessHandle service_process_handle_;
};
-#if defined(OS_WIN)
// They way that the IPC is implemented only works on windows. This has to
// change when we implement a different scheme for IPC.
// Times out flakily, http://crbug.com/70076.
@@ -193,18 +193,21 @@ IN_PROC_BROWSER_TEST_F(ServiceProcessControlBrowserTest,
LaunchServiceProcessControl();
// Make sure we are connected to the service process.
EXPECT_TRUE(process()->is_connected());
+ base::ProcessId service_pid;
+ EXPECT_TRUE(GetServiceProcessSharedData(NULL, &service_pid));
+ EXPECT_NE(static_cast<base::ProcessId>(0), service_pid);
chrome::VersionInfo version_info;
- ForceServiceProcessShutdown(version_info.Version());
+ ForceServiceProcessShutdown(version_info.Version(), service_pid);
WaitForShutdown();
}
IN_PROC_BROWSER_TEST_F(ServiceProcessControlBrowserTest, CheckPid) {
- EXPECT_EQ(0, GetServiceProcessPid());
+ base::ProcessId service_pid;
+ EXPECT_FALSE(GetServiceProcessSharedData(NULL, &service_pid));
// Launch the service process.
LaunchServiceProcessControl();
- EXPECT_NE(static_cast<base::ProcessId>(0), GetServiceProcessPid());
+ EXPECT_TRUE(GetServiceProcessSharedData(NULL, &service_pid));
+ EXPECT_NE(static_cast<base::ProcessId>(0), service_pid);
}
-#endif
-
DISABLE_RUNNABLE_METHOD_REFCOUNT(ServiceProcessControlBrowserTest);
« no previous file with comments | « chrome/browser/service/service_process_control.cc ('k') | chrome/common/service_process_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698