Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 6349018: Avoid using Function.prototype.call in a number of places in our (Closed)

Created:
9 years, 10 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Avoid using Function.prototype.call in a number of places in our builtins files. We should always use %_CallFunction for a couple of reasons: it cannot be overwritten and it does not wrap basic types in wrapper objects. Committed: http://code.google.com/p/v8/source/detail?r=6524

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -65 lines) Patch
M src/date.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/json.js View 3 chunks +3 lines, -3 lines 0 comments Download
M src/messages.js View 9 chunks +17 lines, -35 lines 0 comments Download
M src/mirror-debugger.js View 20 chunks +20 lines, -20 lines 0 comments Download
M src/regexp.js View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 2 chunks +3 lines, -1 line 0 comments Download
M test/mjsunit/debug-backtrace-text.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
9 years, 10 months ago (2011-01-28 09:54:49 UTC) #1
Søren Thygesen Gjesse
9 years, 10 months ago (2011-01-28 09:58:19 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698