Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1738)

Unified Diff: build/util/lastchange.py

Issue 6349010: lastchange: skip over git-svn "rebuilding..." lines (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/util/lastchange.py
diff --git a/build/util/lastchange.py b/build/util/lastchange.py
index 15c0a1fb4fe3665e5b665cd288f459845647bf88..3718c54bda862fac41a0d1a530b9e11b373d5684 100755
--- a/build/util/lastchange.py
+++ b/build/util/lastchange.py
@@ -63,7 +63,9 @@ def FetchSVNRevision(command, directory):
attrs = {}
for line in proc.stdout:
line = line.strip()
- if not line:
+ # git-svn can print out extra "Rebuilding ..." lines, which we don't
+ # care about and want to skip over.
+ if not line or ': ' not in line:
continue
key, val = line.split(': ', 1)
attrs[key] = val
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698