Issue 6348007: Remove outdated comment and forward declaration in pref_value_store.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6348007: Remove outdated comment and forward declaration in pref_value_store.h (Closed)

Created:
9 years, 11 months ago by Mattias Nissler (ping if slow)

Modified:
9 years, 7 months ago

Reviewers:
danno, rohitrao (ping after 24h)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove outdated comment and forward declaration in pref_value_store.h BUG=None TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=72789

Patch Set 1 #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -7 lines)			Patch
	M	chrome/browser/prefs/pref_value_store.h	View		2 chunks	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mattias Nissler (ping if slow)

Is this the reference you were referring to on IRC? Seems I forgot to remove ...

9 years, 11 months ago (2011-01-19 09:39:20 UTC) #1

Mattias Nissler (ping if slow)

Rohit is not responding; Danno, can you take a look?

9 years, 11 months ago (2011-01-25 11:01:07 UTC) #2

rohitrao (ping after 24h)

9 years, 11 months ago (2011-01-25 13:58:18 UTC) #4

On 2011/01/25 11:01:07, Mattias Nissler wrote:
> Rohit is not responding; Danno, can you take a look?

Sorry about that.  For some reason I thought I had already replied to this.  The
comment change LGTM.

I was actually asking about a different TODO/comment, but I no longer see it
anywhere, so I must've been looking at an older tree.  Thanks for explaining
what the cleanup was =)

Expand Messages | Collapse Messages