Issue 6348002: Do not use possibly stale values for cache size, etc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6348002: Do not use possibly stale values for cache size, etc. (Closed)

Created:
9 years, 11 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Vitaly Repeshko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Do not use possibly stale values for cache size, etc. Those value can become invalid if cache gets cleared by GC. Committed: http://code.google.com/p/v8/source/detail?r=6353

Patch Set 2 : Next round #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -63 lines)			Patch
M	src/objects.h	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/objects-debug.cc	View		1 chunk	+7 lines, -6 lines	0 comments	Download
M	src/objects-inl.h	View	1	2 chunks	+23 lines, -3 lines	0 comments	Download
M	src/runtime.cc	View	1	2 chunks	+58 lines, -54 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vitaly Repeshko

LGTM and thanks! -- Vitaly http://codereview.chromium.org/6348002/diff/1/src/runtime.cc File src/runtime.cc (right): http://codereview.chromium.org/6348002/diff/1/src/runtime.cc#newcode10657 src/runtime.cc:10657: MUST_USE_RESULT static MaybeObject* CacheMiss(FixedArray* ...

9 years, 11 months ago (2011-01-17 10:08:33 UTC) #2

antonm

9 years, 11 months ago (2011-01-17 16:46:06 UTC) #3

Thanks a lot for review, Vitaly!

http://codereview.chromium.org/6348002/diff/1/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/6348002/diff/1/src/runtime.cc#newcode10657
src/runtime.cc:10657: MUST_USE_RESULT static MaybeObject* CacheMiss(FixedArray*
cache_obj,
On 2011/01/17 10:08:33, Vitaly wrote:
> The name is probably too generic for this >10K line file.

I've inlined this helper into the runtime function :)

http://codereview.chromium.org/6348002/diff/1/src/runtime.cc#newcode10685
src/runtime.cc:10685: // Function invocation can have cleared the cache.  Reread
all the data.
On 2011/01/17 10:08:33, Vitaly wrote:
> nit: "may have" or "might have". "Can have" sounds more like could do, but
> didn't.

Done.

Expand Messages | Collapse Messages

Issue 6348002: Do not use possibly stale values for cache size, etc. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Next round #

Messages