Issue 6347060: Support the N_PEXT bit of the Mach-O object format....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6347060: Support the N_PEXT bit of the Mach-O object format.... (Closed)

Created:
9 years, 10 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
fbarchard, awong

CC:
chromium-reviews, Mark Mentovai

Base URL:
svn://svn.chromium.org/chrome/trunk/deps/

Visibility:
Public.

Description

Support the N_PEXT bit of the Mach-O object format. This change allows us to set the N_PEXT bit to Mach-O object files when a global symbol has a 'private_extern' extension. BUG=http://www.tortall.net/projects/yasm/ticket/236 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73761

Patch Set 1 #

Patch Set 2 : '' #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -1 line)			Patch
	M	third_party/yasm/patched-yasm/modules/objfmts/macho/macho-objfmt.c	View	1	1 chunk	+20 lines, -1 line	0 comments	Download
	A	third_party/yasm/patches/03_macho_objfmt_private.patch	View	1	1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Hironori Bono

Greetings Frank, Even though I'm asking yasm people to merge this change, is it possible ...

9 years, 10 months ago (2011-02-02 02:37:22 UTC) #1

awong

9 years, 10 months ago (2011-02-03 07:21:15 UTC) #3

I don't understand this code well enough to review the contents.

But I think you're just asking me to approve having a patch checked in.  If so,
then LGTM.

Expand Messages | Collapse Messages