Issue 6347053: Try to mount new filesystem w/ ext2 first, then ext3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6347053: Try to mount new filesystem w/ ext2 first, then ext3. (Closed)

Created:
9 years, 10 months ago by adlr

Modified:
9 years ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
http://git.chromium.org/git/update_engine.git@master

Visibility:
Public.

Description

Try to mount new filesystem w/ ext2 first, then ext3. The new filesystems are ext2, so this is a straightforward fix. TEST=tested before/after on device and saw which filesystem was used BUG=11509 Change-Id: I9844780e9f369312bfd85d6a7e32e537c0a4a779 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=bfabc30

Patch Set 1 #

Patch Set 2 : unittest #

Total comments: 1

Patch Set 3 : fix comment for review #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -5 lines)			Patch
	M	postinstall_runner_action.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	postinstall_runner_action_unittest.cc	View	1 2	2 chunks	+12 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

9 years, 10 months ago (2011-02-01 01:14:45 UTC) #2

LGTM

http://codereview.chromium.org/6347053/diff/2001/postinstall_runner_action_un...
File postinstall_runner_action_unittest.cc (right):

http://codereview.chromium.org/6347053/diff/2001/postinstall_runner_action_un...
postinstall_runner_action_unittest.cc:97: // format it as ext3
update comment

Expand Messages | Collapse Messages